apetavern / grubs

A worms-inspired artillery game for s&box with randomly generated levels.
MIT License
29 stars 7 forks source link

No limit to charged weapon charge #389

Closed cs716 closed 1 month ago

cs716 commented 1 month ago

https://github.com/apetavern/grubs/blob/aeb7910ad8dbada0ba1b1ab30f6e13fed587f667/code/Equipment/Weapons/Weapon.cs#L183

This clamp doesn't actually do anything. In local tests, when I limited the charge to 100, it caused projectiles at full charge to seem pretty weak. Suggest changing the upper limit to 250 in the clamp.

Also we should have it fire immediately if the charge hits 250. There's no way for the user to abort it anyway and they can't aim while charging so no point keeping the charge indicator up.

cs716 commented 1 month ago

Fixed in https://github.com/apetavern/grubs/commit/4d5a02a30f714ac12881074ea7aab03245c135b6