search

apetrycki / daikinskyport

API for accessing a DaikinOne+ Thermostat
63 stars 27 forks source link

Warning message in Core 2024.2.0b1 #95

Closed jeffjumper closed 9 months ago

jeffjumper commented 9 months ago

The February beta is report a warning in the log:

WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.daikinskyport.climate.Thermostat'>) implements HVACMode(s): auto, heat, cool, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/apetrycki/daikinskyport/issues
apetrycki commented 9 months ago

Looks like those Features are only available in the beta version. Adding them gives me an error in the latest stable. Try adding

    | ClimateEntityFeature.TURN_ON
    | ClimateEntityFeature.TURN_OFF

after line 221 of the climate.py file and see if it gets rid of the message for you

jeffjumper commented 9 months ago

I added those 2 lines. Everything still seems to work fine, but the warning is still in the logs. Anything else you want me to try?

apetrycki commented 9 months ago

Hmm, ok. I thought they just needed the features added, but I guess it's a bit more involved. I'll have to see if there's any direction in the documentation or see what the Ecobee integration has done.

apetrycki commented 9 months ago

Looks like you also need to add 

    _enable_turn_on_off_backwards_compatibility = False

to line 398

jeffjumper commented 9 months ago

Yes, that did it. No more warning and the thermostat works fine. Thanks!