apex-dev-tools / apex-ls

Apex language server library
Other
2 stars 1 forks source link

Fix bug in shadow handling on interfaces #229

Closed kjonescertinia closed 1 year ago

kjonescertinia commented 1 year ago

This fixes a bug in shadow handling on interface that is triggered by the download FDN metadata. The fix is also on https://github.com/apex-dev-tools/apex-ls/pull/155 but though better to split out as that PR is taking some time.

The problem here was we could end up with two interface methods each thinking it shadowed the other causing stack overflow in the unused analysis. The cause was the ordering we used to setup the shadow relationship which I have changed to ensure the interfaces are processed in the correct order.