Added more test cases - Githubissues

apex-enterprise-patterns / fflib-apex-common

Common Apex Library supporting Apex Enterprise Patterns and much more!

BSD 3-Clause "New" or "Revised" License

913 stars 518 forks source link

Added more test cases #366

Closed fransf-wtax closed 2 years ago

fransf-wtax commented 3 years ago

Added more test cases to fflib_SObjectSelectorTest and fflib_SObjectUnitOfWorkTest to get coverage for fflib_SObjectSelector and fflib_SObjectUnitOfWork to 75%.

This change is

fransf-wtax commented 3 years ago

Anyone else that can review this? @daveespo ?

AlexSutherlandLiberty commented 2 years ago

Hey @ImJohnMDaniel @stohn777 @daveespo, think we can get this review and approval prioritized/accelerated? ;-) Kind of an embarrassing shortcoming in this library...

ImJohnMDaniel commented 2 years ago

@fransf-wtax, I have been looking at your branch and the changes look good. Having said that, I need to you update your PR branch with the latest before we can approve and merge it to the main code base.

fransf-wtax commented 2 years ago

@ImJohnMDaniel I've rebased on master. Don't know if the tests now still provide >75% coverage, but I can always submit a new PR if that's not the case anymore. Thanks!