search

apex-enterprise-patterns / fflib-apex-common

Common Apex Library supporting Apex Enterprise Patterns and much more!
BSD 3-Clause "New" or "Revised" License
903 stars 514 forks source link

Make sure method return non-null values #413

Open wimvelzeboer opened 2 years ago

wimvelzeboer commented 2 years ago

After upgrading my projects to the latest fflib-apex-common, where some methods were moved from fflib-apex-extensions to fflib-apex-common, I found that a high number of unit-tests were failing.

Then I found out that the getIdFieldValues and getStringFieldValues were suddenly also returning null values, which makes no sense. This fix will make sure these methods always return the values and omit the nulls

This change is Reviewable

ImJohnMDaniel commented 2 years ago

@wimvelzeboer, can you also please check fflib_SObjectsTest.itShouldReturnFieldValues test method. It failed in the CI run for this PR

ImJohnMDaniel commented 2 years ago

@wimvelzeboer, the fflib_SObjectsTest.itShouldReturnFieldValues() test method is still failing with the following error

System.AssertException: Assertion Failed                                
Class.fflib_SObjectsTest.itShouldReturnFieldValues: line 146, column 1

Can you take a look at this please?