Fix to fflib_SObjectMocks.registerDirty(SObject, SObjectField, SObject)

apex-enterprise-patterns / fflib-apex-common

Common Apex Library supporting Apex Enterprise Patterns and much more!

BSD 3-Clause "New" or "Revised" License

903 stars 514 forks source link

Fix to fflib_SObjectMocks.registerDirty(SObject, SObjectField, SObject) #415

Open janskola opened 2 years ago

janskola commented 2 years ago

Fix to registerDirty(SObject, SObjectField, SObject) method with relationship registration

allows correct verification using fflib_Match for all parameters
follows existing implementation of registerNew with relationship and registerRelationship

Other smaller formatting changes without affecting functionality

using Schema.SObjectField instead of Schema.sObjectField (Salesforce preferred name AFAIK)
readability improvements in formatting long lines, unified style
indentation fix for methods commitWork() and below

This change is

ImJohnMDaniel commented 2 years ago

@janskola -- thank you for the submission.

Since this PR is meant to fix somethings, before we proceed with the review, please open a corresponding issue outlining what the details are around this issue and how to reproduce it.

Thanks for the help.

cc: @stohn777 and @daveespo

janskola commented 2 years ago

Thank you for pointing me in the right direction, I've opened issue #416 describing the misbehavior. This PR proposal is fixing the issue.

janskola commented 2 years ago

Hello @ImJohnMDaniel, I've probably done something wrong with this PR and/or associated issue #416, not mentioning you or I'm just impatient (forgive me for that). Issue #416 is created and I hope helps to understand and reproduce the issue. Is there anything I can help with to get this PR merged? Thank you for all efforts on this great library.