search

apex-enterprise-patterns / fflib-apex-common

Common Apex Library supporting Apex Enterprise Patterns and much more!
BSD 3-Clause "New" or "Revised" License
911 stars 517 forks source link

fflib-apex-common | mateuszzw | add addCondition() method to QueryFactory #424

Open mateuszzw opened 2 years ago

mateuszzw commented 2 years ago

Hi @ImJohnMDaniel Since our team had a need for a method that adds to already existing conditions and not just setting them, here's my pull request to add that functionality. Feel free to comment, I'm really curious what you think :)

This change is Reviewable

mateuszzw commented 2 years ago

Hi @ImJohnMDaniel it's open for a long time already. I know you're probably extra busy, but is there any chance for you to take a look at it? Thanks!

chazwatkins commented 1 year ago

@ImJohnMDaniel @stohn777 This looks interesting. What are you're thoughts on this being included?

ImJohnMDaniel commented 1 year ago

This change is under review but we are currently focusing on efforts to incorporate USER_MODE. Once we get this stable, then we will focus on other efforts like this.