Closed jefersonchaves closed 1 year ago
@jefersonchaves In my efforts last week, I overlooked an experimental change which impacted this PR. Please review my change to your PR. Thanks!!
Hello @stohn777: thanks for the review. It seems that a 2nd review is required and I'm not authorized to merge, so I leave this up to you peeps.
@jefersonchaves The original polymorphic test has been failing for a bit. With your PR, motivation was reinvigorated to deal with it too.
You're correct that after further successful review by other maintainers, the PR will be merged.
Hello @stohn777 - Is there anything else I'm missing, or can I help to move forward?
A separate PR was opened to address the unit test failure with Mulicurrency orgs -- the scope of this change on this PR was too broad #437
Uses isMultiCurrencyOrganization before attempting to check the object. Removes code duplication with multiple checks for
UserInfo.isMultiCurrencyOrganization()
. It also can help to make the debugging easier by using variables for thefieldsMap
.This change is![Reviewable](https://reviewable.io/review_button.svg)