apex-enterprise-patterns / fflib-apex-common

Common Apex Library supporting Apex Enterprise Patterns and much more!
BSD 3-Clause "New" or "Revised" License
899 stars 514 forks source link

fflib_SObjectSelector and fflib_SObjectUnitOfWork have insufficient test code coverage. #473

Closed matthewpomar-at-ndr closed 8 months ago

matthewpomar-at-ndr commented 8 months ago

Describe the bug fflib_SObjectSelector and fflib_SObjectUnitOfWork have insufficient test code coverage. When deploying Apex Common to an org, the deploy fails with following errors:

Code Coverage Failure Your code coverage is 73%. You need at least 75% coverage to complete this deployment. fflib_SObjectSelector Your code coverage is 74%. You need at least 75% coverage to complete this deployment. fflib_SObjectUnitOfWork

To Reproduce

Steps to reproduce the behavior:

  1. Install fflib ApexMocks and Apex Common to dev org.
  2. Deploy the classes using DevOps tool of choice, running all tests (or tests included with fflib libraries).
  3. See error above.

Expected behavior fflib libraries should have sufficient test code coverage.

Screenshots and text of error observed

image

Version Latest version as of 12/5/2023.

ImJohnMDaniel commented 8 months ago

G'day @matthewpomar-at-ndr. Thanks for reaching out.

The ApexMocks and Apex Common frameworks each have more than sufficient code coverage to be deployed to a production environment.

Are you, by chance, trying to deploy only certain files instead of the complete framework?

daveespo commented 8 months ago

See https://github.com/apex-enterprise-patterns/fflib-apex-common/issues/239#issuecomment-904646020