daveespo
commented
8 years ago The concrete example that we provided to support reproduces the problem reliably on Spring '16 orgs (about 50% of the time):
@isTest
public class Test_InstanceofBug {
public static testMethod void testTypes(){
Object o = new MyException('payload');
System.assert(o instanceof Exception, 'Expected an instance of Exception; it\'s not!');
}
public class MyException extends Exception { }
}And the problem with the tests that Tom outlined above occurs here: https://github.com/financialforcedev/fflib-apex-mocks/blob/master/src/classes/fflib_ApexMocks.cls#L209
Since the instanceof test sometimes evaluates to true and sometimes it doesn't, the result is that an Exception is returned as a return value vs thrown as an Exception for the mocked function and fails a to be casted to a String
afawcett
tfuda
hubeiyichangzy
agarciaodeian
dfruddffdc
I recently deployed the latest fflib-apex-mocks code into a couple of different Spring '16 Developer Edition org. When I tried running tests in the fflib_ApexMocksTest class, I got a number of failures. I've included details of the failures I received in the table at the bottom of this issue description. I found that these failures appeared to be intermittent, and in Spring '16 orgs only. After some debugging of one particular failure (PatronTicket.fflib_ApexMocksTest.whenStubExceptionTheExceptionShouldBeThrown: line 222, column 1), we discovered what appears to be a platform bug with that causes intermittent failures with statements that use the instanceof operator, like System.assert(ex instanceof MyException) statements. This particular assertion expects the caught Exception to be an "instanceof" the MyException class. Sometimes it is, and sometimes it isn't ;) I have opened a case with Salesforce on this, but I wanted to log it here as an issue, so that others using the fflib-apex-mocks framework are aware of this.