search

apex / up-examples

Example apps, apis, and sites for Up.
389 stars 42 forks source link

bump node version in node 8 & node-micro #67

Closed cwonrails closed 6 years ago

cwonrails commented 6 years ago

None of the bumps in package.json deps go beyond the range specified in the example, but bumping and regenerating yarn.lock should be useful for folks looking to pick up and go after cloning the repo.

The node-spa example has some severely outdated deps, especially after major changes in neutrino v8. I'd be glad to fix those if necessary.

The most consequential changes are in the node-8 and node-micro examples, where node was bumped to the latest LTS in all relevant files (docs, Makefiles, up.json etc.).

lukeed commented 6 years ago

None of the dependency changes were needed since semver would have resolved the latest changes.

Maybe we can find a 8.x node binary that's compatible with Lambda, instead of relying on specific versions.

cwonrails commented 6 years ago

Understood, deps changes commit dropped.

Regarding node versions compatible with Lambda, it's my understanding that Lambda is currently only compatible with node -v 6.10.3 and the node-8 (and by extension the node-micro example) use the hook field in up.json and the Makefile to get around that limitation.

lukeed commented 6 years ago

No worries! 😅

For the second, what I mean is that I wish there was a node-v8.x-linux-x64 instead of node-v8.4.0-linux-x64, so that we wouldn't have to manually update every time.

For example, is one of these Nodesource distros were compatible, it'd be great to use that~!

I don't know what Lambda is actually running on

tj commented 6 years ago

FWIW I don't think we have to keep those up to date, I think people will get the idea from the version numbers in there that they can tweak it to whatever they want. But LGTM otherwise!