Clean up multiple set-cookie header handling - Githubissues

apex / up

Deploy infinitely scalable serverless apps, apis, and sites in seconds to AWS.

https://up.docs.apex.sh

MIT License

8.78k stars 373 forks source link

Clean up multiple set-cookie header handling #729

Open courajs opened 5 years ago

courajs commented 5 years ago

Prerequisites

[x] I searched to see if the issue already exists.
[x] Are you an Up Pro subscriber?

Description

Amazon added support for multiple instances of headers, so we can clean up Set-Cookie support. Rather than doing the goofy CaSE-staggering stuff, we can just use multiValueHeaders: https://aws.amazon.com/about-aws/whats-new/2018/10/amazon-api-gateway-adds-support-for-multi-parameters/ https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html#api-gateway-simple-proxy-for-lambda-output-format

Relevant: #673 and #675 https://github.com/apex/up/blob/5f16b7f99d6c5bd23289e8bf1927a5cce32e3475/internal/proxy/response.go#L63

tj commented 5 years ago

sweet yea I saw that, I'll have to try that soon and verify, would be nice to clean that up! :D