apex / up

Deploy infinitely scalable serverless apps, apis, and sites in seconds to AWS.
https://up.docs.apex.sh
MIT License
8.8k stars 380 forks source link

Specify a Minimum TLS Protocol Version for Custom Domains in API Gateway #774

Open chatch opened 5 years ago

chatch commented 5 years ago

Prerequisites

Description

Currently the TLS version defaults to 1.0. I have to manually upgrade it to 1.2. So it would be nice if it could be specifed in the custom domain config in up.json.

Also consider changing the default to 1.2 instead of 1.0?

AWS docs for the setting are here: https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-custom-domain-tls-version.html

Steps to Reproduce

Deploy with a custom domain. Go to AWS console > API Gateway > custom domains and see the TLS version on the domain is 1.0.

einkoro commented 3 years ago

I would love to see 1.2 as the default or at least a config option as well. I always forget to go change it when spinning up a new project.