search

apexcharts / Blazor-ApexCharts

A blazor wrapper for ApexCharts.js
https://apexcharts.github.io/Blazor-ApexCharts
MIT License
784 stars 91 forks source link

Annotations multiline support - Solution proposal #408

Closed peterboccia closed 6 months ago

peterboccia commented 6 months ago

Hi all,

after a lot of research I found out that ApexCharts has changed the annotations to support multiline. I tried all before: \n,
etcetera, but neither works. And the problem was: in the annotation (X or Y indiscriminately) the property text is use to hold string or array of strings if you want multiple lines to show. Unfortunately in C# we don't have the discriminated union so we need to choose: object to handle everything and put a comment on it, or directly use a List as type. I made the changes as List and it worked: samples of annotations still work as before, added a new one to handle two lines and works as expected. Maybe, it could be easier to handle an object because this would affects the retro-compatibility of the library. I'll make the changes and push the PR. Thanks in advance for you attention

peterboccia commented 6 months ago

Joadan sorry I just noticed that the last version was not published. I also realized I should also update the version number to make the publish work correctly. Can we address this problem?

joadan commented 6 months ago

Hi,

Your PR has been accepted and merge into the main branch. I will prepare a release in a couple of days.