search

apexcharts / Blazor-ApexCharts

A blazor wrapper for ApexCharts.js
https://apexcharts.github.io/Blazor-ApexCharts
MIT License
784 stars 91 forks source link

Solution proposed to issue #408 #409

Closed peterboccia closed 6 months ago

peterboccia commented 6 months ago

As said in the issue #408, this solution to change the type of Label.Text property from string in object could help to handle multiline annotations. I added also the sample to show the results.

!!! ATTENTION: please, if you notice that the vertical annotations is not aligned on the same side: DON'T worry: it's not caused by the Blazor wrapper, or this new feature, but it also happens in the current version as shown in my PEN here and as shown in the photo: image

I'll open an issue on their github and see if they could fix it.

Thank you for your attention and I hope you can find my PR useful.

joadan commented 6 months ago

Hi,

Thank you for the PR, but we would prefer an alternative approach.

In the case where an value can be a single value or a list the approach should be using the BaseType ValueOrList. An example to look at is this one, https://github.com/apexcharts/Blazor-ApexCharts/blob/master/src/Blazor-ApexCharts/Models/MultiType/ImagePaths.cs

Thank you

peterboccia commented 6 months ago

Hi,

Thank you for the PR, but we would prefer an alternative approach.

In the case where an value can be a single value or a list the approach should be using the BaseType ValueOrList. An example to look at is this one, https://github.com/apexcharts/Blazor-ApexCharts/blob/master/src/Blazor-ApexCharts/Models/MultiType/ImagePaths.cs

Thank you

Ok Joadan, I'll give it a look and try to implement this BaseType. Thank you for your reply.

Peter

peterboccia commented 6 months ago

Hi,

Thank you for the PR, but we would prefer an alternative approach.

In the case where an value can be a single value or a list the approach should be using the BaseType ValueOrList. An example to look at is this one, https://github.com/apexcharts/Blazor-ApexCharts/blob/master/src/Blazor-ApexCharts/Models/MultiType/ImagePaths.cs

Thank you

Hello @joadan I just updated the code. Let me know if this is ok. Thank you for the support, I just learned a new way to handle single or multiple data.