search

apexcharts / apexcharts.js

📊 Interactive JavaScript Charts built on SVG
https://apexcharts.com
MIT License
14.26k stars 1.29k forks source link

Scatter plot does not support X and Plus markers #4539

Closed alankalb closed 3 months ago

alankalb commented 3 months ago

Description

When making a scatter plot using 'x', 'X', 'plus' or '+' as the marker shape results in an error as the Scatter plot only supports 'circle', 'square' or 'rect' markers. This is not clear based on documentation or typescript.

Steps to Reproduce

  1. Create a scatter plot
  2. Add markers to the chart options with 'plus', '+', 'x' or 'X' as the shape

Expected Behavior

Scatter plots can use any shape from the MarkerShapeOptions type

Actual Behavior

Scatter plot crashes when using anything other than 'circle', 'square' or 'rect' as marker shapes

Reproduction Link

https://codepen.io/Alan-Kalbfleisch/pen/KKLorJe

junedchhipa commented 3 months ago

Fixed with this commit

junedchhipa commented 2 months ago

Please note that the markers.shape now supports the following options

circle
square
line
plus
cross