Add support of standalone & fix SSR error

apexcharts / ng-apexcharts

ng-apexcharts is an implementation of apexcharts for angular. It comes with one simple component that enables you to use apexcharts in an angular project.

MIT License

319 stars 79 forks source link

Add support of standalone & fix SSR error #290

Closed zip-fa closed 5 months ago

zip-fa commented 11 months ago

What has been done here:

1) Added standalone components support 2) Enabled strict mode everywhere (demo-app & chart component) 3) Converted demo app fully to standalone 4) Bumped Angular peerDependency to v14 (which is not supported too, but will be backward-compatible & non-breaking) 5) Fixed SSR error because of window.ApexCharts call

zip-fa commented 11 months ago

@junedchhipa README.md must be updated and cover standalone topic. That's what I didn't do.

zip-fa commented 11 months ago

i've added lazy-loading and full support of v17 angular and application builder out-of-the-box. This shaved much weight from resulting build.

For those who want to check this out before my PR is accepted, please give it a try: https://www.npmjs.com/package/ng-apexcharts-lazy

zip-fa commented 11 months ago

That's how much KBs got shaved!

junedchhipa commented 10 months ago

Hey @zip-fa Please update the README as well to cover the important topics you've updated in this PR.

BeSaRa commented 6 months ago

any update about this PR because of SSR issue ?

junedchhipa commented 5 months ago

Hey @zip-fa Merging this PR caused a lot of issues (maybe because I missed something while fixing conflicts). I have reverted these changes. Feel free to create a new PR so I can review again. Thanks