search

apexcharts / ng-apexcharts

ng-apexcharts is an implementation of apexcharts for angular. It comes with one simple component that enables you to use apexcharts in an angular project.
MIT License
319 stars 79 forks source link

bump angular 18 #331

Closed damingerdai closed 3 months ago

dabbabi commented 4 months ago

ERESOLVE unable to resolve dependency tree

While resolving: project@1.0.0 Found: @angular/common@18.0.0 node_modules/@angular/common @angular/common@"^18.0.0" from the root project

Could not resolve dependency: peer @angular/common@"^17.0.2" from ng-apexcharts@1.10.0 node_modules/ng-apexcharts ng-apexcharts@"^1.10.0" from the root project

Fix the upstream dependency conflict, or retry this command with --force or --legacy-peer-deps to accept an incorrect (and potentially broken) dependency resolution.

Erkam246 commented 4 months ago

please update for angular 18

liqMats commented 4 months ago

+1

instantgis commented 3 months ago

me too

damingerdai commented 3 months ago

I forked the project and renamed it to ngx-apexcharts. It provides support for angular 18. Before ng-apexcharts officially supports angular 18, you can use ngx-apexcharts as a transition.

reyvaxreecded commented 3 months ago

+1

alanvitor-university commented 3 months ago

+1 please

jdlee726 commented 3 months ago

+1

YuriiDmytryshyn commented 3 months ago

+1 please

nook24 commented 3 months ago

+1

michaelkrog commented 3 months ago

Simply add this to your package.json for now:

  "overrides": {
    "ng-apexcharts": {
      "@angular/common": ">17.0.2",
      "@angular/core": ">17.0.2"
    }
  }

Will force the dependency on Angular for ng-apexcharts to span over major versions.

YuriiDmytryshyn commented 3 months ago

thanks, I did it

пн, 17 черв. 2024 р. о 17:15 Michael Krog @.***> пише:

Simply add this to your package.json for now:

"overrides": { "ng-apexcharts": { @./common": ">17.0.2", @./core": ">17.0.2" } }

Will force the dependency of ng-apexcharts to span over major versions.

— Reply to this email directly, view it on GitHub https://github.com/apexcharts/ng-apexcharts/issues/331#issuecomment-2173543340, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQRVN35X5WHPRZW24GPYYKLZH3VQJAVCNFSM6AAAAABIHCCJYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGU2DGMZUGA . You are receiving this because you commented.Message ID: @.***>

nook24 commented 3 months ago

Many thanks @michaelkrog that worked for me

YuriiDmytryshyn commented 3 months ago

Awesome, thanks for the update!

вт, 18 черв. 2024 р. о 17:29 Juned Chhipa @.***> пише:

Closed #331 https://github.com/apexcharts/ng-apexcharts/issues/331 as completed via #332 https://github.com/apexcharts/ng-apexcharts/pull/332.

— Reply to this email directly, view it on GitHub https://github.com/apexcharts/ng-apexcharts/issues/331#event-13202156702, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQRVN32BZG6T2PKTRNRJFGDZIA747AVCNFSM6AAAAABIHCCJYSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGIYDEMJVGY3TAMQ . You are receiving this because you commented.Message ID: @.***>