ng-apexcharts is an implementation of apexcharts for angular. It comes with one simple component that enables you to use apexcharts in an angular project.
MIT License
329
stars
81
forks
source link
Make apx-chart inputs compatible with Angular strict templates #347
The inputs for apx-chart are optional in chart.component.ts, but are not properly marked as so. This causes issues for projects/libraries using Angular's strictTemplates.
This makes it so that projects/libraries using strictTemplates will not complain about undefined values being passed into inputs when the component expects that can be the case.
All changes
Update Angular minor version
Fix spelling mistakes in the npm copyfile:license script.
Make chart inputs compatible with Angular strictTempaltes.
Add Zone.js to polyfills so that the demo can be run.
Fixes # (issue)
N/A
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] My branch is up to date with any changes from the main branch
New Pull Request
The inputs for
apx-chart
are optional inchart.component.ts
, but are not properly marked as so. This causes issues for projects/libraries using Angular'sstrictTemplates
.Going from this:
@Input() chart: ApexChart;
To this:
@Input() chart?: ApexChart;
(i.e.@Input() chart: ApexChart | undefined
)This makes it so that projects/libraries using
strictTemplates
will not complain aboutundefined
values being passed into inputs when the component expects that can be the case.All changes
copyfile:license
script.strictTempaltes
.Fixes # (issue) N/A
Type of change
Checklist: