search

apexcharts / ng-apexcharts

ng-apexcharts is an implementation of apexcharts for angular. It comes with one simple component that enables you to use apexcharts in an angular project.
MIT License
321 stars 80 forks source link

Angular 9 compatibility #53

Closed mits87 closed 4 years ago

mits87 commented 4 years ago

Hi,

can you add compatibility with Angular 9? Currently when I'm doing npm install I'm getting those warnings:

npm WARN ng-apexcharts@1.2.1 requires a peer of @angular/common@^8.0.0 but none is installed. You must install peer dependencies yourself. npm WARN ng-apexcharts@1.2.1 requires a peer of @angular/core@^8.0.0 but none is installed. You must install peer dependencies yourself.

Thank you in advance.

rokerkony commented 4 years ago

the same applies now for Angular 10

junedchhipa commented 4 years ago

The PR #69 by @sp90 fixes this. Can you please upgrade to the latest version 1.5.0 and check again?

rokerkony commented 4 years ago

@junedchhipa not really, there was allowed only ng9. I created a PR: https://github.com/apexcharts/ng-apexcharts/pull/80

You will just need to publish a new version afterwards

rokerkony commented 4 years ago

Hey @junedchhipa, thank you for merging my PR. Just a question, when can we expect a new version released?

junedchhipa commented 4 years ago

New version ng-apexcharts@1.5.1 released