search

apexcharts / vue3-apexcharts

📊 Vue-3 component for ApexCharts
MIT License
314 stars 35 forks source link

Ensure that events defined in chart options are called too. #105

Closed tiegz closed 5 months ago

tiegz commented 5 months ago

Currently vue3-apexcharts defines the same callback for each of apexcharts events, and those callbacks just calls "emit()" so that the e.g. @mousemove='some-handler'-style definition works:

https://github.com/apexcharts/vue3-apexcharts/blob/02b0a1af917c78d791087a6fc6dbad379e04dbf9/src/vue3-apexcharts.js#L137-L138

But the docs don't mention this limitation anywhere, so most people unsuccessfully define events in the chart options like the apexcharts docs describe.

This fix calls any defined events in the chart options after the emit() is called, so the chart options' events will work.

fix https://github.com/apexcharts/vue3-apexcharts/issues/20

leoatfentech commented 4 months ago

Has this been released yet ? I'm working with "apexcharts": "^3.49.2" and "vue3-apexcharts": "^1.5.3" and it seems to not be there yet ?

junedchhipa commented 4 months ago

This is yet to be released.

rabrowne85 commented 2 months ago

@junedchhipa any updates on a new release for this? Just ran into this exact issue.

junedchhipa commented 2 months ago

released vue3-apexcharts@v1.6.0

ggrote commented 2 months ago

This commit introduced the issues #121, #120, #119, #118, (maybe #117) and #115. Maybe it should be reverted or a fix is needed.

Zippanova commented 1 month ago

This commit has caused many regressions in v1.6.0 which is now unstable. I agree with @ggrote this should be reverted or fixed, and v1.6.0 needs this patch to make the latest package version stable again.

junedchhipa commented 1 month ago

released vue3-apexcharts@1.7.0

Zippanova commented 1 month ago

@junedchhipa Release v1.7.0 did not address the issue introduced in this commit. Both versions 1.6.0 and 1.7.0 now contain this regression. I would suggest reverting the entirety of changes in v1.6.0 until these can be regression tested against all issues below, which remain unresolved.

This commit introduced the issues #121, #120, #119, #118, (maybe #117) and #115. Maybe it should be reverted or a fix is needed.

ggrote commented 1 month ago

I would suggest reverting the entirety of changes in v1.6.0 until these can be regression tested against all issues below, which remain unresolved.

My changes did not introduce any issues. If you revert the config event change and keep my changes everything works fine.