search

apfelbox / PHP-File-Download

A class to help with creating downloads for files in PHP
BSD 3-Clause "New" or "Revised" License
71 stars 18 forks source link

Added sendDownload() bool param $forceDownload and extra MIME types #1

Closed roblambell closed 10 years ago

apfelbox commented 10 years ago

Thanks for your contribution! What do you think - is this list sufficient or should we pull something like skyzyx/mimetypes to add a real long and comprehensive list of mime types?

roblambell commented 10 years ago

My pleasure. I think a comprehensive list would be much better, skyzyx/mimetypes looks excellent. Do you have a preference with regards how this is implemented: requiring a class, including a JSON document (stdicon.com/mimetypes is handy too), directly incorporating code?

apfelbox commented 10 years ago

Hm, I think this might be a good time to finally add composer support for this small lib. We could then just add it as a dependency, so that it is automatically included and one could use the class directly.

(although this would raise the minimum requirement of this class to PHP5.3, but this shouldn't be an issue, since PHP 5.2 is deprecated for a long time now).

I will add composer support, if you want you can resend your $forceDownload-PR (to be included in contributor fame ;-D ), otherwise I would just add it myself afterwards.