search

apgoetz / jolly

Apache License 2.0
12 stars 3 forks source link

MSRV? #6

Closed 0323pin closed 1 year ago

0323pin commented 1 year ago

Hi,

I've just packaged jolly for NetBSD, it works great locally on my machine. A future wish, if you don't mind. It would be nice to be able to customize the background, foreground and highlight colors of the application :)

In order to merge the package, I need to ask you one thing. NetBSD currently has Rust-1.64 as default. I'm running Rust-1.66 on my machine and have already been asked to revert a few package updates because they don't build with 1.64. So, what's the minimum required version to build jolly?

I've assigned myself as package maintainer so, I'll keep it up-to-date ;) Regards and thank you for this tool.

apgoetz commented 1 year ago

Thanks for the feedback. I have added theming support as a feature request in #7

Regarding MSRV, jolly depends on iced for its gui toolkit, and while MSRV is not explicitly mentioned by name by iced, it is pretty clear that the only supported rustc is latest stable. iced 0.6.0 is already using GATs which were only stabilized in rust 1.65.

I will add a note to readme describing MSRV, but unfortunately I don't think that will solve the NetBSD problems.

0323pin commented 1 year ago

@apgoetz Thanks!

I will add a note to readme describing MSRV, but unfortunately I don't think that will solve the NetBSD problems.

No problem, we are not stucked with 1.64 😄 I was expecting 1.66 to be merged this week but, for some reason it has been delayed. I'll merge jolly as soon it lands. For now, I'm keeping it on my own repository.

Will post you a note when it's done. If you would like, I can also do a PR adding install instructions to the README.MD

apgoetz commented 1 year ago

OK, glad to hear you will get it merged.

Feel free to open a PR on the README when you are ready. I think it would be hilarious if the only OS with detailed installation instructions is NetBSD.

0323pin commented 1 year ago

Please feel free to comment if you have anything you would like to change, https://codeberg.org/pin/netbsd/src/branch/master/Packages/jolly

0323pin commented 1 year ago

@apgoetz It took longer than expected but, merged today.