search

aphadeon / OpenGame.exe

A custom Ruby-powered game engine that supports RPG Maker games.
24 stars 11 forks source link

Game title is now read from the Game.ini file #1

Closed felixjones closed 8 years ago

felixjones commented 8 years ago

Completed this todo mostly to familiarise myself with the project's source. Can be considered a minor addition.

felixjones commented 8 years ago

The inclusion of the equals sign as part of the .ini key search may be a bad idea. The .ini standards do not describe if blank spaces may be on either side of the equals sign, however this is still something to consider implementing for just-in-case reasons.

; Current supported ini structure
Title=My Game Title
; Possible permutations of ini that are not supported
Title = My Game Title
Title= My Game Title
Title =My Game Title
aphadeon commented 8 years ago

This looks fantastic, but please read the CONTRIBUTING.MD in the project root. (Sorry, aggravating, I know. Neccessary seeing I want the engine useable for commercial purposes.)

felixjones commented 8 years ago

Read and updated, sorry!

Commit 7bf0185 has been properly formatted too