Open aphalo opened 10 months ago
I found one cause of spurious normalization-warning messages due to an optimization used mainly in 'ggspectra'. It is now fixed. Also added support for collections of spectra to normalization-related functions. Afr2A()
remains to be implemented. Testing is not yet done. I need to check that the bug raised in this issue is actually fixed and add a unit test.
Afr2A()
methods.Main problem seems to be the poorly documented and possibly inconsistently implemented assumption that A
and Afr
are always defined as "internal"
irrespective of the TfrType
setting of the filter_spct
object.
convertTfrType()
needs to be fixed to make use of the Rfr.constant
stored in the filter.properties
attribute.A2T()
and T2A()
need to be tested with and without Rfr.constant
available in the filter.properties
attribute.This is for the most part done. As there are some pending taks, I push the Milestone to the next one 0.11.2.
Was:
T2A()
andnormalise()
errors and missingAfr2A()
method.T2A()
seems to not work correctly whenTfr == 0
andRfr != 0
. The problem could be caused by a wrongly setTfrType
attribute in the data I was using, or could be an error in the computations. In the first case a validity test would be missing and in the second case, a plain bug.The missing
Afr2A()
would have been useful for testing and diagnosing the problem, and adding it should be the first step.