apheleia-project / jbs-build-issues

0 stars 0 forks source link

Timeouts #11

Closed rnc closed 5 months ago

rnc commented 5 months ago

Currently we set timeouts in a number of places:

rg v12.Duration
pkg/reconciler/dependencybuild/buildrecipeyaml.go
229:                            Timeout:         &v12.Duration{Duration: time.Hour * 3},
370:                            Timeout: &v12.Duration{Duration: time.Hour * 3},

pkg/reconciler/dependencybuild/dependencybuild.go
575:            Pipeline: &v12.Duration{Duration: time.Hour * 3},
576:            Tasks:    &v12.Duration{Duration: time.Hour * 3},
595:    pr.Spec.Timeouts = &tektonpipeline.TimeoutFields{Pipeline: &v12.Duration{Duration: time.Hour * 3}}

This was done in:

https://github.com/redhat-appstudio/jvm-build-service/commit/8e42508cdbaa2444c3d03bef392e0900b5cf0416 https://github.com/redhat-appstudio/jvm-build-service/commit/227366acbb649083bd7c83463c57c657f603d3e6#diff-3d35324e4d54c7a4b63264f4856fdb63d8630c06c9e6f96f24cd04be9af28c08R254

References:

Unfortunately it appears we can't just set it in one place as otherwise many values default to the global timeout value.

However, the kotlin build times out so :