search

apheleia-project / jbs-build-issues

0 stars 0 forks source link

EnforceVersion #5

Closed rnc closed 4 months ago

rnc commented 6 months ago

Within jvm-build-data its a boolean but then gets changed to be a string internally and filled in to match the requested version. I think instead it should be maintained to be a boolean.

It is only used in three places:

In the latter gradle-build.sh its not clear why its needed. It sets the tag to the enforceVersion string.

params.TAG should surely already be at that version?

In the former two, its used both as a boolean and a string. The version is also available in project_version so that could be used to supply the version.

rnc commented 5 months ago

Another potential issue is that enforce version is denoted to be a string in the yaml so changing it could have deprecation issues.

rnc commented 4 months ago

This is also potentially related to code changes in https://github.com/redhat-appstudio/jvm-build-service/pull/317 - while enforce version might be required in some scenarios, I am not sure why we need to 'recreate' the tag given the git repository should already have cloned that tag. That PR should potentially be partially reverted until we analyse why we (might) need it.

rnc commented 4 months ago

@stuartwdouglas I think we should also consider this especially the gradle portion in the last comment as I really not sure if any builds actually need it any longer (especially given there has been so many changes to Gradle support).