Closed rnc closed 5 months ago
AFAIK the build fails without git lfs, but I never really liked installing it as a non-official RH package, and I really don't like that this build has random jar files in the git repo. I am happy to get rid of LFS, the solution might be to manually convert any builds we need that need LFS into another format.
While within https://jvmshield.dev/builds/build/0cf1755bf1a6b20861c11567955fc700 the build succeeds it fails to deploy with a message of
(from https://jvmshield.dev/api/builds/attempts/logs/6d1eda49-6165-49eb-9edb-875a6a906bcf )
Note that the build-request-processor image is built by jib and does not have auxilliary programs such as git-lfs - which is what its pre-push hook has :
So, the question is how does that git-lfs hooks get installed. I think its because the builder image has git-lfs installed in https://github.com/redhat-appstudio/jvm-build-service-builder-images/blob/main/Dockerfile.template#L28 and was added in https://github.com/redhat-appstudio/jvm-build-service-builder-images/pull/18 by @dwalluck but I don't know the history of that or any builds it relates to.
I don't know why we need git-lfs especially as we do not call any of its commands (e.g. git lfs clone) and having it installed means the hooks are created which then affects when we try to push the sources to the gitlab repository. My suggestion would be to remove git-lfs from the builder image.
ICU is using git-lfs in https://github.com/unicode-org/icu/blob/release-73-1/.gitattributes#L79
Thoughts @stuartwdouglas @dwalluck ?