search

aphex / vite-plugin-ngrok

A Vite plugin for seamless integration with ngrok, allowing you to easily share your local development server with anyone, anywhere.
15 stars 2 forks source link

domain needs to be fully qualified #3

Open Soviut opened 1 month ago

Soviut commented 1 month ago

In my local ngrok.yml I use the subdomain prop on my tunnels. However, the Javascript config prefers domain. After a fair bit of trial and error, I figured out that the domain needs to be fully qualified my-tunnel.ngrok.io, not just my-tunnel.

It would be good to update the readme so that this is clearer since the example is ambiguous, showing

domain: 'my-domain',

I propose it be updated to

domain: 'my-domain.ngrok.app',

I'd be willing to make a PR for this.

aphex commented 1 week ago

@Soviut makes sense to me feel free to send it my way.

Soviut commented 1 week ago

@aphex PR is read https://github.com/aphex/vite-plugin-ngrok/pull/4

Feel free to close this thread when it's merged.