aphp / eds-scikit

eds-scikit is a Python library providing tools to process and analyse OMOP data
https://aphp.github.io/eds-scikit
BSD 3-Clause "New" or "Revised" License
35 stars 5 forks source link

Viz trajectories #41

Closed JCharline closed 1 year ago

JCharline commented 1 year ago

Patient trajectories vizualisation

Description

PR addressing issue #30.

Function to plot individual event sequences. Events can be one-time/continuous, categorized in event families or relative from an index date.

Vizualisation parameters are also accepted, such as event colors, labels, and figure parameters.

Checklist

Thomzoy commented 1 year ago

Hi @JCharline ! Thanks a lot for this PR, it looks great ! Could you maybe rebase and run pre-commit so that the CI is passing ?

pre-commit install
pre-commit run --all-files
codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2e4c960). Click here to learn what that means. Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #41 +/- ## ======================================= Coverage ? 83.80% ======================================= Files ? 82 Lines ? 2488 Branches ? 0 ======================================= Hits ? 2085 Misses ? 403 Partials ? 0 ``` | [Impacted Files](https://codecov.io/gh/aphp/eds-scikit/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp) | Coverage Δ | | |---|---|---| | [eds\_scikit/datasets/\_\_init\_\_.py](https://codecov.io/gh/aphp/eds-scikit/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp#diff-ZWRzX3NjaWtpdC9kYXRhc2V0cy9fX2luaXRfXy5weQ==) | `81.48% <100.00%> (ø)` | | | [eds\_scikit/datasets/synthetic/event\_sequences.py](https://codecov.io/gh/aphp/eds-scikit/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp#diff-ZWRzX3NjaWtpdC9kYXRhc2V0cy9zeW50aGV0aWMvZXZlbnRfc2VxdWVuY2VzLnB5) | `100.00% <100.00%> (ø)` | | | [eds\_scikit/plot/event\_sequences.py](https://codecov.io/gh/aphp/eds-scikit/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp#diff-ZWRzX3NjaWtpdC9wbG90L2V2ZW50X3NlcXVlbmNlcy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

JCharline commented 1 year ago

Thanks @Vincent-Maladiere for the review ! Happy to merge 🥳

Thomzoy commented 1 year ago

Very nice PR, thanks @JCharline for the feature and @Vincent-Maladiere for the review ;) One last thing, could you rebase main and add your contribution to the changelog ?

JCharline commented 1 year ago

Thanks @Thomzoy, it should be okay by now !