aphp / eds-scikit

eds-scikit is a Python library providing tools to process and analyse OMOP data
https://aphp.github.io/eds-scikit
BSD 3-Clause "New" or "Revised" License
35 stars 5 forks source link

Fix: Switch default `to_koalas` in `HiveData._read_table`. to False #42

Open Vincent-Maladiere opened 1 year ago

Vincent-Maladiere commented 1 year ago

Description

The to_koalas argument has been deprecated in _read_table since it wasn't used. Returning koalas DataFrame during this step allows for more predictable behavior and fewer worries due to OOM errors.

When to_koalas is set to True, we raise a warning to indicate that this argument is not used. Since this argument is True by default, we raise this warning for every table to be read, which is unpleasant for the user.

Therefore, this PR suggests setting to_koalas to False by default.

Checklist

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud