aphp / eds-scikit

eds-scikit is a Python library providing tools to process and analyse OMOP data
https://aphp.github.io/eds-scikit
BSD 3-Clause "New" or "Revised" License
35 stars 5 forks source link

Feat: support array type for `datetime_ref` in `plot_age_pyramid()` #43

Closed Vincent-Maladiere closed 1 year ago

Vincent-Maladiere commented 1 year ago

Description

Checklist

strayMat commented 1 year ago

I struggle with resolving the conversation but LGTM !

Vincent-Maladiere commented 1 year ago

I need to add some documentation then we'll be good to merge :)

Vincent-Maladiere commented 1 year ago

I'm just waiting for https://github.com/aphp/eds-scikit/pull/41 to be merged so that I can complete the documentation!

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (24bf047) 83.80% compared to head (099b337) 83.84%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #43 +/- ## ========================================== + Coverage 83.80% 83.84% +0.03% ========================================== Files 82 82 Lines 2488 2494 +6 ========================================== + Hits 2085 2091 +6 Misses 403 403 ``` | [Impacted Files](https://app.codecov.io/gh/aphp/eds-scikit/pull/43?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp) | Coverage Δ | | |---|---|---| | [eds\_scikit/plot/age\_pyramid.py](https://app.codecov.io/gh/aphp/eds-scikit/pull/43?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp#diff-ZWRzX3NjaWtpdC9wbG90L2FnZV9weXJhbWlkLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Vincent-Maladiere commented 1 year ago

@strayMat finally, it's merged :)

strayMat commented 1 year ago

So coole ! Thanks !