aphp / eds-scikit

eds-scikit is a Python library providing tools to process and analyse OMOP data
https://aphp.github.io/eds-scikit
BSD 3-Clause "New" or "Revised" License
35 stars 5 forks source link

Bioclean edit #51

Closed svittoz closed 5 months ago

svittoz commented 9 months ago

Description

This PR intends to fix some issues related to bioclean module and to make it easier to use while keeping core functionalities.

Checklist

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 99.72973% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.46%. Comparing base (553677e) to head (237b723).

Files Patch % Lines
eds_scikit/utils/framework.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #51 +/- ## ========================================== + Coverage 83.22% 83.46% +0.23% ========================================== Files 83 86 +3 Lines 2492 2534 +42 ========================================== + Hits 2074 2115 +41 - Misses 418 419 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thomzoy commented 6 months ago

TMP

It's a very nice PR ! I'm writing down some temporary remarks regarding the doc here: