aphp / eds-scikit

eds-scikit is a Python library providing tools to process and analyse OMOP data
https://aphp.github.io/eds-scikit
BSD 3-Clause "New" or "Revised" License
35 stars 5 forks source link

allows naming - move improve performance file #54

Closed svittoz closed 6 months ago

svittoz commented 8 months ago

Description

In improve_performance function :

Checklist

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4e29cbd) 83.74% compared to head (74a4576) 83.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #54 +/- ## ========================================== - Coverage 83.74% 83.22% -0.53% ========================================== Files 82 83 +1 Lines 2492 2492 ========================================== - Hits 2087 2074 -13 - Misses 405 418 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TheooJ commented 7 months ago

Hi Simon !

Also, I think improve_performance should be accessible from eds_scikit, but shouldn't be written in __init__.py. Writing functions there makes it hard to follow the codebase. I suggest writing it elsewhere and making it accessible by setting from path.to.file import improve_performance in the __init__.py

svittoz commented 7 months ago

Hi Simon !

Also, I think improve_performance should be accessible from eds_scikit, but shouldn't be written in __init__.py. Writing functions there makes it hard to follow the codebase. I suggest writing it elsewhere and making it accessible by setting from path.to.file import improve_performance in the __init__.py

I moved improve_performance into io folder and import it in the init as you suggested.