Closed svittoz closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4e29cbd
) 83.74% compared to head (74a4576
) 83.22%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi Simon !
ks
operations are rewritten, making them eager: https://github.com/aphp/eds-scikit/blob/053a943fc0266726c9a4b0c547ef5e2ce64e239f/eds_scikit/utils/custom_implem/custom_implem.py#L68 Also, I think improve_performance
should be accessible from eds_scikit
, but shouldn't be written in __init__.py
. Writing functions there makes it hard to follow the codebase. I suggest writing it elsewhere and making it accessible by setting from path.to.file import improve_performance
in the __init__.py
Hi Simon !
- "Allows app_name parameter so that user can distinguish two kernels from the same project." -> this is really useful !
- "Lazy operations does not seem to work" which operation are you referring to ? Note that some
ks
operations are rewritten, making them eager: https://github.com/aphp/eds-scikit/blob/053a943fc0266726c9a4b0c547ef5e2ce64e239f/eds_scikit/utils/custom_implem/custom_implem.py#L68Also, I think
improve_performance
should be accessible fromeds_scikit
, but shouldn't be written in__init__.py
. Writing functions there makes it hard to follow the codebase. I suggest writing it elsewhere and making it accessible by settingfrom path.to.file import improve_performance
in the__init__.py
I moved improve_performance into io folder and import it in the init as you suggested.
Description
In improve_performance function :
Checklist