aphp / edsnlp

Modular, fast NLP framework, compatible with Pytorch and spaCy, offering tailored support for French clinical notes.
https://aphp.github.io/edsnlp/
BSD 3-Clause "New" or "Revised" License
113 stars 29 forks source link

Adicap pipeline #123

Closed aricohen93 closed 2 years ago

aricohen93 commented 2 years ago

Description

New NER pipeline to identify ADICAP codes

Checklist

codecov-commenter commented 2 years ago

Codecov Report

Base: 94.32% // Head: 94.42% // Increases project coverage by +0.09% :tada:

Coverage data is based on head (6fb8514) compared to base (a37ce74). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #123 +/- ## ========================================== + Coverage 94.32% 94.42% +0.09% ========================================== Files 159 163 +4 Lines 4529 4591 +62 ========================================== + Hits 4272 4335 +63 + Misses 257 256 -1 ``` | [Impacted Files](https://codecov.io/gh/aphp/edsnlp/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp) | Coverage Δ | | |---|---|---| | [edsnlp/pipelines/factories.py](https://codecov.io/gh/aphp/edsnlp/pull/123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp#diff-ZWRzbmxwL3BpcGVsaW5lcy9mYWN0b3JpZXMucHk=) | `100.00% <100.00%> (ø)` | | | [edsnlp/pipelines/ner/adicap/adicap.py](https://codecov.io/gh/aphp/edsnlp/pull/123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp#diff-ZWRzbmxwL3BpcGVsaW5lcy9uZXIvYWRpY2FwL2FkaWNhcC5weQ==) | `100.00% <100.00%> (ø)` | | | [edsnlp/pipelines/ner/adicap/decoder.py](https://codecov.io/gh/aphp/edsnlp/pull/123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp#diff-ZWRzbmxwL3BpcGVsaW5lcy9uZXIvYWRpY2FwL2RlY29kZXIucHk=) | `100.00% <100.00%> (ø)` | | | [edsnlp/pipelines/ner/adicap/factory.py](https://codecov.io/gh/aphp/edsnlp/pull/123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp#diff-ZWRzbmxwL3BpcGVsaW5lcy9uZXIvYWRpY2FwL2ZhY3RvcnkucHk=) | `100.00% <100.00%> (ø)` | | | [edsnlp/pipelines/ner/adicap/patterns.py](https://codecov.io/gh/aphp/edsnlp/pull/123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp#diff-ZWRzbmxwL3BpcGVsaW5lcy9uZXIvYWRpY2FwL3BhdHRlcm5zLnB5) | `100.00% <100.00%> (ø)` | | | [edsnlp/utils/resources.py](https://codecov.io/gh/aphp/edsnlp/pull/123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp#diff-ZWRzbmxwL3V0aWxzL3Jlc291cmNlcy5weQ==) | `94.44% <100.00%> (+2.77%)` | :arrow_up: | | [edsnlp/pipelines/core/contextual\_matcher/models.py](https://codecov.io/gh/aphp/edsnlp/pull/123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp#diff-ZWRzbmxwL3BpcGVsaW5lcy9jb3JlL2NvbnRleHR1YWxfbWF0Y2hlci9tb2RlbHMucHk=) | `94.66% <0.00%> (+1.33%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aphp)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

aricohen93 commented 2 years ago
Thomzoy commented 2 years ago

Looks good ! As the ContextualMatcher was upgraded in the same time, I took the liberty to create a new PR with your ADICAP pipeline adapted to the new Matcher, see #124

It might be better to split into 2 separate PR, but this way we can easily check if everything works fine together