aphp / edsnlp

Modular, fast NLP framework, compatible with Pytorch and spaCy, offering tailored support for French clinical notes.
https://aphp.github.io/edsnlp/
BSD 3-Clause "New" or "Revised" License
112 stars 29 forks source link

feat: allow Qualifiers to match on spangroups #128

Closed Thomzoy closed 1 year ago

Thomzoy commented 2 years ago

Description

Proposition for allowing Qualifiers to look for matches in sentences present in doc.spans[key]. It would extend the current on_ents_only argument by adding another on_spangroups argument

Another way of doing this could be to be more general with, e.g. a on parameter that could be set to tell the Qualifiers to match on

However, this approach would induce many API breaking changes, so maybe the first approach is preferable

Checklist

Thomzoy commented 2 years ago

Actualy some work was already done in the dates pipelines, so I took some inspiration from it

percevalw commented 1 year ago

Closing as this was merged in #213