aphp / edsnlp

Modular, fast NLP framework, compatible with Pytorch and spaCy, offering tailored support for French clinical notes.
https://aphp.github.io/edsnlp/
BSD 3-Clause "New" or "Revised" License
115 stars 29 forks source link

Reason for pydantic <1.10.0 #164

Closed strayMat closed 2 years ago

strayMat commented 2 years ago

Context

I am using pydantic factory for my study module to generate mock data. It relies on pydantic >=1.10.

Description:

edsnlp precises that pydantic should < 1.10.0 . Is there a specific reason that we do not want to accept later version of pydantic ?

percevalw commented 2 years ago

Hi @strayMat, thanks for letting us know about this :) Indeed there seems to be no reason for this, we will update the constraint in the next version soon to be released.

strayMat commented 2 years ago

Great ! thank you so much ! 🤩

(Since the PR is alrdeay merged, I close the issue, but let me know if in the future you prefer to close this kind of issue yourself).