Open Aremaki opened 6 months ago
Hi Adam, it's true that the current options are a bit confusing!
mode = independent
, window = 1
-> ok, it's softmaxmode = marginal/joint
, window = 0
-> ok, it's the standard CRFmode = marginal/joint
, window = n
-> ok, this is the windowed CRFEverything else is incorrect:
mode = independent
, window != 1
-> windows have no effectmode = marginal/joint
, window == 1
-> transitions have no effectLooking at it this way, I wonder if we could remove the independent
mode and replace it with window=1
.
btw, the bug we were discussing the other day was fixed in #259
Yes I agree, it seems that "independent" mode is not necessary, as we can remove CRF with the window argument (window = 1)
eds.ner_crf pipeline needs argument
window = 1
to remove CRF instead of the argumentmode = "independent"
Description
The mode "independent" is supposed to remove the CRF in the architecture model.
Possible solution
When "mode = independent" assigns
window = 1
How to reproduce the bug
Your Environment