search

aphp / edsnlp

Modular, fast NLP framework, compatible with Pytorch and spaCy, offering tailored support for French clinical notes.
https://aphp.github.io/edsnlp/
BSD 3-Clause "New" or "Revised" License
111 stars 29 forks source link

date cues #265

Closed cvinot closed 1 month ago

cvinot commented 6 months ago

Suggestion of date cues as mentioned in #253

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.94%. Comparing base (084aa4f) to head (86383ef). Report is 52 commits behind head on master.

:exclamation: Current head 86383ef differs from pull request most recent head 08f45d5. Consider uploading reports for the commit 08f45d5 to get more accurate results

Files Patch % Lines
edsnlp/pipes/misc/dates/dates.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #265 +/- ## ========================================== - Coverage 96.95% 96.94% -0.02% ========================================== Files 255 255 Lines 8591 8595 +4 ========================================== + Hits 8329 8332 +3 - Misses 262 263 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

percevalw commented 6 months ago

Thanks ! We'll try to review this asap

cvinot commented 1 month ago

Hey @percevalw any chance to see this merged in a short term future ? It isn't much, I basicaly just repeated the cues you already had in negations/hypothesis in dates.

Sorry If the test don't pass I don't really see the link with the related modifications.