aphp / edsnlp

Modular, fast NLP framework, compatible with Pytorch and spaCy, offering tailored support for French clinical notes.
https://aphp.github.io/edsnlp/
BSD 3-Clause "New" or "Revised" License
115 stars 29 forks source link

[Numpy version] Incompatibility version with scikit-eds #97

Closed JCharline closed 2 years ago

JCharline commented 2 years ago

Description

edsnlp requires a version of numpy >= 1.21 whereas scikit-eds requires numpy < 1.20 (probably due to pyspark issues).

How to reproduce the bug

requirements.txt from edsnlp here requirements.txt from scikit:

pgpasslib
psycopg2-binary
pandas
numpy<1.20.0  # https://github.com/databricks/koalas/pull/2166
koalas
altair
loguru

Your Environment

SamirPS commented 2 years ago

does edsnlp really need numpy 1.21 or numpy < 1.20 is enough ?

SamirPS commented 2 years ago

does edsnlp really need numpy 1.21 or numpy < 1.20 is enough ?

@percevalw

percevalw commented 2 years ago

This was a hacky fix because of some numpy C header issues, but it didn't work well in practice.

I'm closing this issue as it has been solved by https://github.com/aphp/edsnlp/pull/109, thanks again for opening the issue !