aphp / edspdf

EDS-PDF is a generic, pure-Python framework for text extraction from PDF documents. It provides the machinery to use rule- or machine-learning-based approaches to classify text blocs between body and meta-data.
https://aphp.github.io/edspdf/
BSD 3-Clause "New" or "Revised" License
42 stars 6 forks source link

Dev install documentation and dependencies fix #16

Closed ian-fox closed 1 year ago

ian-fox commented 1 year ago

Attrs is imported in structures.py but is not actually installed by default. It appears to be some transitive dependency of one of the dev dependencies, so it works fine if you install in dev mode but if you're installing the package without that you got an import error.

I thought this was small enough that it wasn't worth adding a test in the suite for, but if you disagree please let me know and I can add one.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (42473ae) 94.78% compared to head (e724e13) 94.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16 +/- ## ======================================= Coverage 94.78% 94.78% ======================================= Files 32 32 Lines 1974 1974 ======================================= Hits 1871 1871 Misses 103 103 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

percevalw commented 1 year ago

Hi ! thanks for this, could you rebase against the latest commit of main? That should fix the documentation check

ian-fox commented 1 year ago

Thanks for the feedback, applied both and rebased!