Closed christoph-kluge closed 2 years ago
Missing php 8.1 support using dev version for now https://github.com/thephpleague/fractal/issues/526
This addresses #15 #16 #17
now laravel9 illuminate/routing version is 9.0 but dingo-api just require ^7.0|^8.0 how can i fix it
@suguer without further details it's hard to tell. My first quess: You're using the wrong version and/or fork.
Did you add my fork as repository to your composer.json
?
@christoph-kluge Did you add my fork as repository to your composer.json? no , I do not change my composer.json anything
Using version ^3.1 for api-ecosystem-for-laravel/dingo-api ./composer.json has been updated Running composer update api-ecosystem-for-laravel/dingo-api Loading composer repositories with package information Updating dependencies Your requirements could not be resolved to an installable set of packages.
Problem 1
You can also try re-running composer require with an explicit version constraint, e.g. "composer require api-ecosystem-for-laravel/dingo-api:*" to figure out if any version is installable, or "composer require api-ecosystem-for-laravel/dingo-api:^2.1" if you know which you need.
Installation failed, reverting ./composer.json and ./composer.lock to their original content.
I see. So without changing your composer you'll be not able to test my fork. This pull-request is just a proposal to this library and does not necessarily mean that the maintainers will merge it.
If you want to test my non-official fork then you should to explicitly define this in your composer.json.
https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository
ok. take the liberty to ask .what parameters should I write to composer.json . I don't know how to write composer.json very well thx very much
@christoph-kluge excuse me , can you teach me how to write to composer.json . I try it, but failure
@suguer please check out the last link to the composer documentation how to load a package from vcs. You need my fork's github-url and the branch name. You can find this information on top of this page right below the title of the PR and replace the values in these examples.
If you click on my source branch you'll get redirected to my fork's URL and the branch. https://github.com/christoph-kluge/dingo-api
and laravel-9-support
. It's important to prefix dev-{branchname}
as mentioned in the documentation.
okk, my composer.json is right , but still failed
Loading composer repositories with package information Updating dependencies Your requirements could not be resolved to an installable set of packages.
Problem 1
When could this pull request be merged?
For anyone trying to get @christoph-kluge's PR working locally before it being merged, you need to add these to your composer.json:
"repositories": [
{
"type": "vcs",
"url": "git@github.com:christoph-kluge/dingo-api.git"
},
{
"type": "vcs",
"url": "git@github.com:dmason30/blueprint.git"
},
{
"type": "vcs",
"url": "https://github.com/annuh/fractal.git"
}
],
Then require the package like so:
composer require api-ecosystem-for-laravel/dingo-api dev-laravel-9-support
For anyone trying to get @christoph-kluge's PR working locally before it being merged, you need to add these to your composer.json:
"repositories": [ { "type": "vcs", "url": "git@github.com:christoph-kluge/dingo-api.git" }, { "type": "vcs", "url": "git@github.com:dmason30/blueprint.git" }, { "type": "vcs", "url": "https://github.com/annuh/fractal.git" } ],
Then require the package like so:
composer require api-ecosystem-for-laravel/dingo-api dev-laravel-9-support
solved! extremely grateful!
@tobias-kuendig thank you for adding this here.
I did change the repository-urls from git@
to https://
and added your install instructions to the MR description.
composer update
passed without errors for me with this guide. Nice! :tada: The downside that on my project all requests I have gives me 500 Internal Server Error without any backtrace message now. So gonna debug it.
Any idea when does this PR could be merged?
Not working with Fractal
When are we merging this PR?
Waiting this as well
Hey all, sorry for the wait - I've been absent due to first holiday in 3.5 years, you know how it is :cry:
Now that this is in a group though, I am able to and would be happy to give access to people who are committed and able to help maintain this package - please let me know if you are interested!
Just some updates for versions, https://github.com/api-ecosystem-for-laravel/dingo-api/pull/22
Please use tag v4.0.0 to get all the latest changes for laravel 9
@specialtactics I would be interested. Would you be up for a chat regarding short/mid/long-term plans for this lib? Can I reach you in some slack/discord channel?
Back in the days laravel was missing a lot of api-related features. Since then a lot changed and we might reduce a bit of boilerplate within this package.
Yes @christoph-kluge I agree, are you on the main laravel slack by any chance?
Description
In general tests look good for L9 + PHP8+ but changes are not backward compatible
Waiting for dependent packages
Tests overview
getContent()
changed return behavior)Install instructions
Test and install this locally first. Thanks to @tobias-kuendig for sharing the instructions.