explode can't be null in php 8 set default include input to empty string

api-ecosystem-for-laravel / dingo-api

Replacement repo for dingo/api

BSD 3-Clause "New" or "Revised" License

265 stars 58 forks source link

Closed germ1f closed 2 years ago

germ1f commented 2 years ago

Hello,

I have a suggest to apply because explode can't be null if include input not exist (it gives a php warning)

Sorry if my PR is not perfect, this bug appeared when I upgraded to Laravel 9 and php8 and changes dingo-api package with your.

christoph-kluge commented 2 years ago

Hallo @germ1f, thank you for your contribution. 👍

I did append a test-case to cover this scenario.