api-platform / admin

A beautiful and fully-featured administration interface builder for hypermedia APIs
https://api-platform.com/docs/admin/
MIT License
481 stars 130 forks source link

Total Items overwritten by partial total #435

Closed louisboulagnon closed 2 years ago

louisboulagnon commented 2 years ago

Hello

API Platform version(s) affected:

=2.8.0

Description
There seems to be a problem in the "total" computing since the #426 commit, the second if should be an else if https://github.com/api-platform/admin/blob/c2090ca346ddf34e654589554f6998378318594f/src/hydra/dataProvider.ts#L628-L642 Right now the total is overwritten by the partial pagination trick which is currently not working (#379) hence breaking normal pagination as well

Thanks for the work here, cheers