api-platform / admin

A beautiful and fully-featured administration interface builder for hypermedia APIs
https://api-platform.com/docs/admin/
MIT License
477 stars 131 forks source link

null violations error body fix #528

Closed PawelSuwinski closed 4 months ago

PawelSuwinski commented 4 months ago

I seems that PR #515 broke violations list processing based on error body so validation messages are not shown any more in the form (?), this would never happen:

https://github.com/api-platform/admin/blob/a3292d81ddab39c04152e239e641920dd6f156ff/src/hydra/fetchHydra.ts#L79-L81

I think that we should step back and let jsonld do the math like it was in previous version. With this fix validation errors are shown again in the form. Please correct me if I missed anything here.

dominikboniecki commented 4 months ago

@alanpoulain please look at this change, the bug is very critical for global error handling in a whole project

dunglas commented 4 months ago

Thank you!