api-platform / api-doc-parser

Transforms a Hydra API doc in an intermediate representation that can be used for various tasks such as creating smart API clients, scaffolding code or building administration interfaces.
MIT License
104 stars 71 forks source link

204 response code is invalid #106

Closed dawid-focusly closed 2 years ago

dawid-focusly commented 2 years ago

What is the reason that 204 response code is invalid? 204 (no content) is a valid and recommended DELETE response and it does'nt mean that request is unsuccessful. It's also default api platform behaviour and breaks react admin delete feature.

https://github.com/api-platform/api-doc-parser/blob/7421a6239f42e631c994490a6595c383134527f4/src/hydra/fetchJsonLd.ts#L27

alanpoulain commented 2 years ago

Solved by https://github.com/api-platform/api-doc-parser/pull/107.