search

api-platform / create-client

Generate React or Vue.js-based Progressive Web Apps from an Hydra-enabled API. Also support React Native.
https://api-platform.com/docs/client-generator/
MIT License
374 stars 132 forks source link

fix: don't ignore login data set via CLI params (regression from #316) #325

Closed Sirs0ri closed 2 years ago

Sirs0ri commented 2 years ago

In attempting to fix an empty options object overshadowing the options set by the user via CLI, #316 mistakenly adjusted options.username, options.password and options.bearer to be attributes of the newly introduced parserOptions. They should, however, still refer to the options object that holds all the information previously set via CLI arguments.

I also added two comments to make the difference between the two sets of options more clear.

Q A
Branch? current stable version branch for bug fixes
Tickets n.a.
License MIT
Doc PR n.a.
alanpoulain commented 2 years ago

LGTM, you need to fix the CS too.

Sirs0ri commented 2 years ago

@alanpoulain What do you mean by "CS"?

I just addressed the one linter error I missed (in a squashed commit, therefore the force push).

alanpoulain commented 2 years ago

CS: Code Style (the linter error). Thank you!

Sirs0ri commented 2 years ago

oh, gotcha. You're welcome!