Closed Sirs0ri closed 2 years ago
LGTM, you need to fix the CS too.
@alanpoulain What do you mean by "CS"?
I just addressed the one linter error I missed (in a squashed commit, therefore the force push).
CS: Code Style (the linter error). Thank you!
oh, gotcha. You're welcome!
In attempting to fix an empty
options
object overshadowing the options set by the user via CLI, #316 mistakenly adjustedoptions.username
,options.password
andoptions.bearer
to be attributes of the newly introducedparserOptions
. They should, however, still refer to theoptions
object that holds all the information previously set via CLI arguments.I also added two comments to make the difference between the two sets of options more clear.