api-platform / demo

Demo app for the API Platform framework
https://demo.api-platform.com
MIT License
301 stars 202 forks source link

Improve "Install"-section in README.md #228

Closed Chris53897 closed 3 years ago

Chris53897 commented 3 years ago

Hi. If you just follow the instruction in the Install-Section in README.md you will get the error. yaml: line 53: did not find expected tag URI

The problem is the first "!" in each line. So you have to change that. MERCURE_PUBLISHER_JWT_KEY: ${MERCURE_PUBLISHER_JWT_KEY:-!ChangeMe!} MERCURE_SUBSCRIBER_JWT_KEY: ${MERCURE_SUBSCRIBER_JWT_KEY:-!ChangeMe!}

I would suggest a) Add the info to the install-section b) just set a valid default password so the demo works out of the box (security needs to be considered, but it should be overwritten by docker-compose.prod.yml for production)

rowanparker commented 3 years ago

I think that error is not related to a bad yaml file, but rather that there is an outstanding bug with the latest version of docker-compose.

https://github.com/docker/compose-cli/issues/2028

Try changing back to Docker Compose v1 and it should work.

Chris53897 commented 3 years ago

@rowanparker Thanks. v2 has a lot of bugs ;(