search

api-platform / docs

API Platform documentation
https://api-platform.com/docs/
164 stars 1.06k forks source link

Doctrine ORM & PHP 8 attributes #1411

Open wiese opened 3 years ago

wiese commented 3 years ago

The "Getting started" docs state

Note: Doctrine ORM doesn't support PHP 8 attributes at this time, but support should be added soon (a Pull Request already exists).

yet the linked issue is merged and the demo app shows use of attributes – so this sentence seems to be outdated (granted, hard to track).

Not sure if this is supposed to be updated right away or you are planning to change the recommended writing style in a future release, so creating a ticket instead of a PR.

Thanks for your hard work!

dunglas commented 3 years ago

We need to wait for support for attributes to be the default in Symfony (Symfony 6) and to be supported by MakerBundle (https://github.com/symfony/maker-bundle/pull/920), but I think that we can already update the main branch!

In the meantime, we should change the wording!

dunglas commented 2 years ago

We now use Doctrine attributes by default. The documentation can now be updated and https://github.com/api-platform/docs/pull/1413/files reverted to mention only the attributes.

StephaneBullier commented 2 years ago

Hi @dunglas,

This demand has been done @wiese already ? But there is only a problem about the length of the new line added. How can I correct this ?