api-platform / schema-generator

PHP Model Scaffolding from Schema.org and other RDF vocabularies
https://api-platform.com/docs/schema-generator/
MIT License
458 stars 108 forks source link

PR CI checks fail the lock file is not up to date with the latest changes in composer.json #416

Closed Angatar closed 10 months ago

Angatar commented 10 months ago

My PR (#415) only includes the relevant code directly related to the new feature added however the CI checks fail and according to the CI logs it seems the composer.lock was not updated for the required symfony/phpunit-bridge package used for running the tests: Here is a part of the CI Build&Test logs returned:

Created project in /home/runner/work/schema-generator/schema-generator/vendor/bin/.phpunit/phpunit-9-0 composer.json has been updated Installing dependencies from lock file Verifying lock file contents can be installed on current platform. Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run composer update or composer update <package name>.

  • Required package "symfony/phpunit-bridge" is not present in the lock file.

Has it to be fixed in the CI pipeline with a composer update additional step or do I need to include the updated composer.json/composer.lock files in my PR?

Originally posted by @Angatar in https://github.com/api-platform/schema-generator/issues/415#issuecomment-1840860671

Angatar commented 10 months ago

Thanks for #417, it has updated the composer.json and composer.lock files, which had for side effect to fix this issue.